search

libertyernie / brawltools

BrawlBox and BrawlLib
http://forums.kc-mm.com/index.php?topic=67847.0
143 stars 31 forks source link

BrawlBox does not release memory when an OutOfMemoryException occurs #226

Closed red031000 closed 4 years ago

red031000 commented 4 years ago

Loading a large brsar file can sometimes cause a System.OutOfMemoryException (which can be alleviated by moving to 64-bit, but that's not what this issue is about) when this has occurred, all the memory that's been loaded remains there and doesn't get released, leading to more OutOfMemoryExceptions when opening smaller files that are normally able to be opened fine.

red031000 commented 4 years ago

I have been testing this with an x86 build of master, and pbr_sound.brsar from the PAL version of Pokemon Battle Revolution

red031000 commented 4 years ago

issue was resolved in #227