search

libertyernie / rstmcpp

Port of BrawlLib RSTM encoder to C++
ISC License
0 stars 0 forks source link

Stereo channel marker is "wrong" #3

Open Algorithmus opened 1 year ago

Algorithmus commented 1 year ago

We've been finding in recent versions of vgmstream, bcwav files generated by rstmcpp with stereo channels appear to no longer work. https://github.com/vgmstream/vgmstream/issues/1335 The culprit appears to be here: https://github.com/libertyernie/rstmcpp/blob/master/cwav.h#L105

Currently it works on real 3DS hardware, so it's not easy to detect unless you're using vgmstream.

Is there any reason why we use 0x1f[index] instead of 0x1f00 or is that really just a bug?

libertyernie commented 1 year ago

The code was pretty much just copied from an older version of BrawlCrate, if I recall correctly - I'm not sure whether it should really be 0x1f00+i either. I'd check the code of the current BrawlCrate and/or VGAudio (both in C#) and see if they do it any differently.

Algorithmus commented 1 year ago

VGAudio appears to just use SampleData as is. Thanks anyways, I will just update rstmcpp on my end to not add the index.