search

libertymutual / herman

Herman is a tool to simplify deployment of AWS Services using ECS and Lambda, and the provisioning of various AWS services.
Other
33 stars 21 forks source link

Add Unit Tests for ECS Cluster Push #39

Open rdbatch02 opened 6 years ago

rdbatch02 commented 6 years ago

The ECS Cluster Push functionality needs unit tests, we don't have a good way of validating new functionality (outside manual testing).

AmmadHassanPro commented 6 years ago

Just landed on his project and it seems to be a good place to contribute to. Can I get some more info, on what kind of unit tests we are looking at?

rdbatch02 commented 6 years ago

Hey @AmmadHassanPro, the bulk of the functionality for this issue in particular lives here https://github.com/libertymutual/herman/blob/master/src/main/java/com/libertymutualgroup/herman/aws/ecs/cluster/EcsClusterPush.java. I would say that we're generally looking for tests that verify that the AWS SDK calls happen with the proper inputs, or calls to other packages within the project (like calling out to push a CFT). I think you'll definitely need to mock some of the functionality that the AWS SDK has, since we're looking for tests that can run on their own and not necessarily running against an actual AWS account.

Does that help? Certainly let us know if you have any questions and we'll try to respond as quickly as possible. Thanks in advance for your contribution!

AmmadHassanPro commented 6 years ago

Hey , Thanks for the heads up. I will go through the project and will let you know , if I have any question.