search

libertysoft3 / saidit

The reddit open source fork powering SaidIt
https://saidit.net
Other
226 stars 40 forks source link

Fix approve/remove buttons #123

Closed CrystalVulpine closed 1 year ago

CrystalVulpine commented 1 year ago

I removed the approve button from posts that aren't removed, because it's unnecessary and can lead to mods and admins accidentally approving them (could still happen with the big green one when it's removed or reported, but it should be less common now). I also added the the "spam" and "remove" buttons to removed items, in case mods want to change the removal type (spam vs. not spam) without having to approve them first.

libertysoft3 commented 1 year ago

Can your second change lead to confusion for mods? By showing "spam" and "remove" on something that has already been spammed or removed, they might think that they haven't acted on it already, when they have.

I like the first change. I also have no power to get these things deployed on saidit.net. You have to talk to the boss about it. You should become the new maintainer!

CrystalVulpine commented 1 year ago

@libertysoft3 It should not confuse mods. Removed items show up to mods in red with big buttons, and say [ removed ]. In fact it already shows all three buttons when it's removed by a spam filter or an admin. But for some reason it hides them when a moderator removes it manually.

CrystalVulpine commented 1 year ago

@libertysoft3 I did speak with magnora about adding an admin frontend for reddit's user bans, but not the other two PRs. I'm probably going to refer him to these pull requests since he just got back.

CrystalVulpine commented 1 year ago

@libertysoft3 I don't think I can be the new maintainer. I've never operated a website before, so I'll have trouble dealing with server issues. I've used sockets on localhost before but never actually tried connecting to the internet, and even setting up reddit and saidit was frustrating (granted those were mostly VM issues, not network problems). And I'm mostly a C programmer, so I struggle with all the layers of abstraction that higher-level languages have. Secondly it would likely be a privacy issue for me on the irl side, and I also may not always be available. I am able to make basic features and changes to the software though, I do that all the time. And I do have some experience with saidit's codebase, because I made a joke reddit clone on localhost a couple of years ago and made a bunch of changes.

libertysoft3 commented 1 year ago

Okay, thanks for explaining. Nice changes so far.