Port to Ubuntu 18 LTS - Githubissues

libertysoft3 / saidit

The reddit open source fork powering SaidIt

https://saidit.net

Other

231 stars 40 forks source link

Port to Ubuntu 18 LTS #13

Open libertysoft3 opened 5 years ago

libertysoft3 commented 5 years ago

Major components of task:

[x] update install script
[ ] dependency hell, old fbthrift required for baseplate and the activity service is brutal
[x] find an alternative for upstart events: reddit-start, reddit-stop, reddit-flush. Using systemd service depedencies
[ ] re-implement upstart services as systemd services
[ ] much testing
[ ] create new issue to support classic sysvinit for devuian, etc. with a parameter to the install script

wizzwizz4 commented 5 years ago

Ooh… You sure about systemd? I know it makes things easier, but there are a lot of issues with it. This is probably idealism over practicality, but see here for details.

Also note that Reddit proper hasn't been tested against systemd, and systemd's _truly bizarre_behaviour could introduce several security issues – this isn't such an idealism issue, and actually requires attention.

libertysoft3 commented 5 years ago

I personally have mixed feelings about systemd myself, but requiring an unpopular linux distro to run this codebase is taking it backwards. this is saidit, but this is also a continuation of reddit open source. (i imagined two separate code bases but no one cares so it's all saidit out of the box).

90% of the systemd port is straightforward. The only tricky bit is upstart has an "events" concept that reddit uses but systemd doesn't have.

I'm actually pretty far on this task but I am stuck here, at the porting events thing. And I'm in way over my head. I can push my slop if anyone wants to help with this one. I think the answer is using dependent systemd services, and making a little hierarchy instead of using events.

ghost commented 5 years ago

R u still working on Ubuntu 14.04 for website?

libertysoft3 commented 5 years ago

@wemre Yeah we're still using Ubuntu 14 for now. We need to switch off of it asap since security updates have stopped coming.

If you have any experience porting upstart to systemd, we'd love some help.

donCarlosOne commented 5 years ago

have you made in progress with this? I have a client that wants to deploy saidit as the base for a new system

libertysoft3 commented 5 years ago

@donCarlosOne I'm working on it now but it's very challenging due to some of the dependencies. There should be news within the next 2 weeks.