search

libertysoft3 / saidit

The reddit open source fork powering SaidIt
https://saidit.net
Other
228 stars 40 forks source link

Upgrade jQuery to 3.x #35

Open wizzwizz4 opened 5 years ago

wizzwizz4 commented 5 years ago

I don't know of the boundaries to this, but jQuery 2.11 is pretty old. Can we get a new one?

It'll help with development, for those of us who use jQuery, because newer is faster.

IAmYhvr commented 5 years ago

This might help: https://github.com/jquery/jquery-migrate

libertysoft3 commented 5 years ago

There's a concept of server side jquery in this codebase. Need R+D to decide if this is an easy change or not.

libertysoft3 commented 5 years ago

I'm calling this an enhancement although I know there are security concerns with older jQuery which is maybe an argument for calling it a bug.

wizzwizz4 commented 5 years ago

Security issues?

libertysoft3 commented 5 years ago

@wizzwizz4 Just medium level stuff, I don't see much substantial https://retirejs.github.io/retire.js/

wizzwizz4 commented 5 years ago

XSS. That's really substantial for a site like Saidit. And one of them is anchor-based, which means you can't even detect it server-side (though that's fixed). Another (which is still present) might be triggered by a new expando feature.

This is a bug.