search

libertysoft3 / saidit

The reddit open source fork powering SaidIt
https://saidit.net
Other
228 stars 40 forks source link

Reduce isinstance abuse #38

Closed wizzwizz4 closed 4 years ago

wizzwizz4 commented 5 years ago

https://github.com/libertysoft3/saidit/commit/c082dbab4a0d09968dcfa660b3186eb6ea892fbb#r33462392

Is instance is used a lot in the codebase.

This suggests that some functions are pseudo-overloaded, or are otherwise being dishonest about what information they require. This is a maintenance nightmare! Can we clean this up?

libertysoft3 commented 5 years ago

I don't see the issue. Can you provide further background info about why isinstance is bad, and what your proposed alternative is?

libertysoft3 commented 4 years ago

Not an issue, no impact