search

libertysoft3 / saidit

The reddit open source fork powering SaidIt
https://saidit.net
Other
228 stars 40 forks source link

Javascript for server-side expando onclick doesn't check the mouse button #45

Closed wizzwizz4 closed 4 years ago

wizzwizz4 commented 5 years ago

Title. This basically breaks right-click.

Also, while you're at it, adding touch events would also be good.

libertysoft3 commented 5 years ago

So we should have the expando href be the real href so right click -> copy link location works? That sounds good.

Why touch events, doesn't touch trigger our click event just fine?

wizzwizz4 commented 5 years ago

I don't know; I just have a vague recollection that it wouldn't.