Closed curtisdelicata closed 5 months ago
eb86073525
)[!TIP] I'll email you at genealogysoftwareuk@gmail.com when I complete this pull request!
Here are the GitHub Actions logs prior to making any changes:
e91fd9e
Checking app/Filament/Resources/DnaResource.php for syntax errors... β app/Filament/Resources/DnaResource.php has no syntax errors!
1/1 βChecking app/Filament/Resources/DnaResource.php for syntax errors... β app/Filament/Resources/DnaResource.php has no syntax errors!
Sandbox passed on the latest main
, so sandbox checks will be enabled for this issue.
I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.
app/Filament/Resources/DnaResource.php
β https://github.com/liberu-genealogy/genealogy-laravel/commit/93ec504c69fa01236347f838571fe2f9b5d3614d Edit
Modify app/Filament/Resources/DnaResource.php with contents:
β’ Change the job dispatch call from `ImportDna::dispatch(...)` to `DnaMatching::dispatch(...)`.
β’ Ensure that the parameters passed to `DnaMatching::dispatch(...)` are appropriate for the `DnaMatching` job. If the `DnaMatching` job requires different parameters, adjust the dispatch call accordingly. However, based on the issue description, it seems the parameters can remain the same.
β’ Before making this change, verify that the `DnaMatching` job exists within the application, likely under the `app/Jobs` directory. If it does not exist or if modifications are needed, those changes should be made separately and are not covered by this specific issue.
β’ This modification is necessary to ensure that the correct job is dispatched when a file is uploaded through the DNA resource form. It aligns the application's functionality with the current requirements as described in the issue.
--- +++ @@ -22,7 +22,7 @@ { return $form->schema([ Forms\Components\TextInput::make('name')->required()->maxLength(255), - FileUpload::make('attachment')->required()->maxSize(100000)->directory('dna-form-imports')->visibility('private')->afterStateUpdated(ImportDna::dispatch($request->user(), $manager->storagePath($path), $state)), + FileUpload::make('attachment')->required()->maxSize(100000)->directory('dna-form-imports')->visibility('private')->afterStateUpdated(DnaMatching::dispatch($request->user(), $manager->storagePath($path), $state)), ]); }
app/Filament/Resources/DnaResource.php
β Edit
Check app/Filament/Resources/DnaResource.php with contents:
Ran GitHub Actions for 93ec504c69fa01236347f838571fe2f9b5d3614d:
I have finished reviewing the code for completeness. I did not find errors for sweep/fix_dna_upload
.
π‘ To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request.Something wrong? Let us know.
This is an automated message generated by Sweep AI.
Details
Rename job dispatch from ImportDna to DnaMatching. Make sure that DnaMatching laravel job is correctly dispatched and the function is called by the file upload in the file app/Filament/Resources/DnaResource.php
Checklist
- [X] Modify `app/Filament/Resources/DnaResource.php` β https://github.com/liberu-genealogy/genealogy-laravel/commit/93ec504c69fa01236347f838571fe2f9b5d3614d [Edit](https://github.com/liberu-genealogy/genealogy-laravel/edit/sweep/fix_dna_upload/app/Filament/Resources/DnaResource.php#L25-L25) - [X] Running GitHub Actions for `app/Filament/Resources/DnaResource.php` β [Edit](https://github.com/liberu-genealogy/genealogy-laravel/edit/sweep/fix_dna_upload/app/Filament/Resources/DnaResource.php#L25-L25)