Add Unit Tests for GedcomExporter and GedcomImporter - Githubissues

liberu-genealogy / laravel-gedcom

Gedcom reading and writing for Laravel 11

https://www.liberu.co.uk

MIT License

76 stars 50 forks source link

Add Unit Tests for GedcomExporter and GedcomImporter #13

Closed sweep-ai[bot] closed 3 months ago

sweep-ai[bot] commented 3 months ago

PR Feedback (click)

[ ] 👍 Sweep Did Well
[ ] 👎 Sweep Needs Improvement
I created this PR to address this rule:

"All new business logic should have corresponding unit tests."

Description

This PR introduces unit tests for the GedcomExporter and GedcomImporter classes. These tests ensure that the new business logic in these classes works as expected under different scenarios. The tests cover functionalities such as exporting and importing data, handling of non-existent directories, and verifying the correct data format in the output file.

Summary of Changes

Created a new test file tests/Unit/GedcomExporterTest.php for the GedcomExporter class. This file contains tests that cover the export functionality, including directory creation, data fetching, and file writing.
Created a new test file tests/Unit/GedcomImporterTest.php for the GedcomImporter class. This file contains tests that cover the import functionality, including file parsing and data importing.
Utilized Laravel's built-in testing functionalities to mock file system operations and database queries, ensuring that the tests are focused on the logic within the GedcomExporter and GedcomImporter classes.

These tests will help maintain the code quality and ensure that the functionalities work as expected.

sweep-ai[bot] commented 3 months ago

Rollback Files For Sweep

[ ] Rollback changes to tests/Unit/GedcomExporterTest.php
[ ] Rollback changes to tests/Unit/GedcomExporterTest.php
[ ] Rollback changes to tests/Unit/GedcomImporterTest.php
[ ] Rollback changes to tests/Unit/GedcomImporterTest.php