liberu-genealogy / laravel-gedcom

Gedcom reading and writing for Laravel 11
https://www.liberu.co.uk
MIT License
76 stars 50 forks source link

Sweep: laravel 11 #18

Closed curtisdelicata closed 3 months ago

curtisdelicata commented 3 months ago

Details

Improve to make use of new laravel 11 features and refactor. Update dependencies in composer.json

Checklist - [X] Modify `composer.json` ✓ https://github.com/liberu-genealogy/laravel-gedcom/commit/5a10be2404f87facbf61a775d5ec18abd05e5500 [Edit](https://github.com/liberu-genealogy/laravel-gedcom/edit/sweep/laravel_11/composer.json#L4-L7) - [X] Running GitHub Actions for `composer.json` ✓ [Edit](https://github.com/liberu-genealogy/laravel-gedcom/edit/sweep/laravel_11/composer.json#L4-L7) - [X] Modify `composer.json` ✓ https://github.com/liberu-genealogy/laravel-gedcom/commit/321920dc68e0fb50ec6ecb2e61083a9f576c3025 [Edit](https://github.com/liberu-genealogy/laravel-gedcom/edit/sweep/laravel_11/composer.json#L22-L25) - [X] Running GitHub Actions for `composer.json` ✓ [Edit](https://github.com/liberu-genealogy/laravel-gedcom/edit/sweep/laravel_11/composer.json#L22-L25) - [X] Modify `src/ServiceProvider.php` ✓ https://github.com/liberu-genealogy/laravel-gedcom/commit/255a1ac0214701ba124d268d43f74f67ac33f665 [Edit](https://github.com/liberu-genealogy/laravel-gedcom/edit/sweep/laravel_11/src/ServiceProvider.php) - [X] Running GitHub Actions for `src/ServiceProvider.php` ✓ [Edit](https://github.com/liberu-genealogy/laravel-gedcom/edit/sweep/laravel_11/src/ServiceProvider.php)
sweep-ai[bot] commented 3 months ago

🚀 Here's the PR! #21

See Sweep's progress at the progress dashboard!
💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: 9d374e5e53)

[!TIP] I'll email you at genealogysoftwareuk@gmail.com when I complete this pull request!


Actions (click)

GitHub Actions✓

Here are the GitHub Actions logs prior to making any changes:

Sandbox logs for 2cd4182
Checking composer.json for syntax errors... ✅ composer.json has no syntax errors! 1/1 ✓
Checking composer.json for syntax errors...
✅ composer.json has no syntax errors!

Sandbox passed on the latest main, so sandbox checks will be enabled for this issue.


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I think are relevant in decreasing order of relevance (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/liberu-genealogy/laravel-gedcom/blob/2cd41820b874f9fc38d39c1212db13cc5e15a6e2/composer.json#L1-L27

Step 2: ⌨️ Coding

--- 
+++ 
@@ -5,7 +5,8 @@
   "require": {
     "php": ">=8.2",
     "laravel-liberu/php-gedcom": "^1.4",
-    "doctrine/dbal": "^2.8|^3.0"
+    "doctrine/dbal": "^3.0",
+    "laravel/framework": "^11.0"
   },
   "license": "MIT",
   "autoload": {

Ran GitHub Actions for 5a10be2404f87facbf61a775d5ec18abd05e5500:

--- 
+++ 
@@ -5,7 +5,8 @@
   "require": {
     "php": ">=8.2",
     "laravel-liberu/php-gedcom": "^1.4",
-    "doctrine/dbal": "^2.8|^3.0"
+    "doctrine/dbal": "^3.0",
+    "laravel/framework": "^11.0"
   },
   "license": "MIT",
   "autoload": {
@@ -21,8 +22,8 @@
     }
   },
   "require-dev": {
-    "rector/rector": "*",
-    "driftingly/rector-laravel": "^0.25.0",
-    "phpunit/phpunit": "^11.0"
+    "rector/rector": "^0.14.0",
+    "driftingly/rector-laravel": "^0.26.0",
+    "phpunit/phpunit": "^12.0"
   }
 }

Ran GitHub Actions for 321920dc68e0fb50ec6ecb2e61083a9f576c3025:

--- 
+++ 
@@ -11,11 +11,8 @@
     public $app;
     public function register()
     {
-        $this->commands([
-            GedcomImporter::class,
-        ]);
-
-        $this->app->bind('FamilyTree365/laravel-gedcom:parser', fn() => new GedcomParser());
+        $this->app->singleton('FamilyTree365/laravel-gedcom:parser', fn() => new GedcomParser());
+        $this->commands(GedcomImporter::class);
     }

     public function boot()

Ran GitHub Actions for 255a1ac0214701ba124d268d43f74f67ac33f665:


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/laravel_11.


🎉 Latest improvements to Sweep:
  • New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
  • Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
  • Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request.Something wrong? Let us know.

This is an automated message generated by Sweep AI.