[Sweep Rules] Refactor Writer.php to improve modularity - Githubissues

liberu-genealogy / php-gedcom

Gedcom reading and writing for PHP 8.3

https://www.liberu.co.uk

MIT License

74 stars 40 forks source link

[Sweep Rules] Refactor Writer.php to improve modularity #10

Closed sweep-ai[bot] closed 4 months ago

sweep-ai[bot] commented 4 months ago

PR Feedback (click)

[ ] 👍 Sweep Did Well
[ ] 👎 Sweep Needs Improvement
I created this PR to address this rule:

"Refactor large functions to be more modular."

Description

This PR refactors the convert method in Writer.php to improve modularity. The changes separate the responsibility of adding the format information from the convert method, making the code more modular and adhering to best practices. Additionally, the $format parameter is added back to the convert method to allow for flexibility in specifying the format.

Summary of Changes

Created a new file FormatInformation.php in the src directory to handle format information.
Modified the convert method in Writer.php to call the addFormatInformation method and concatenate the format information with the rest of the output.
Added the $format parameter back to the convert method with a default value of self::GEDCOM55.

Please review and merge these changes to improve the modularity of the convert method in Writer.php.

sweep-ai[bot] commented 4 months ago

Rollback Files For Sweep

[ ] Rollback changes to src/FormatInformation.php
[ ] Rollback changes to src/FormatInformation.php
[ ] Rollback changes to src/Writer.php
[ ] Rollback changes to src/Writer.php