Add Unit Tests for FormatInformation and Writer Classes - Githubissues

liberu-genealogy / php-gedcom

Gedcom reading and writing for PHP 8.3

https://www.liberu.co.uk

MIT License

74 stars 39 forks source link

Add Unit Tests for FormatInformation and Writer Classes #18

Closed sweep-ai[bot] closed 5 months ago

sweep-ai[bot] commented 6 months ago

PR Feedback (click)

[ ] 👍 Sweep Did Well
[ ] 👎 Sweep Needs Improvement
I created this PR to address this rule:

"All new business logic should have corresponding unit tests."

Description

This PR introduces unit tests for the FormatInformation and Writer classes in the php-gedcom project. The tests cover the new business logic introduced in these classes, ensuring their correctness and robustness.

Changes include:

Creation of a new test file tests/FormatInformationTest.php to cover the addFormatInformation method in the FormatInformation class.
Addition of tests in tests/WriterTest.php to cover the changes in the Writer class, specifically the integration of FormatInformation::addFormatInformation within the Writer::convert method.

Summary

Added unit tests for FormatInformation::addFormatInformation.
Added/Modified unit tests for Writer::convert to cover its new logic.
Ensured all tests cover edge cases and validate the expected behavior of the new logic.

sweep-ai[bot] commented 6 months ago

Rollback Files For Sweep

[ ] Rollback changes to tests/FormatInformationTest.php
[ ] Rollback changes to tests/FormatInformationTest.php
[ ] Rollback changes to tests/WriterTest.php
[ ] Rollback changes to tests/WriterTest.php
[ ] Rollback changes to tests/WriterTest.php
[ ] Rollback changes to tests/WriterTest.php