[Sweep Rules] Refactor large `convert` method in `Writer.php` - Githubissues

liberu-genealogy / php-gedcom

Gedcom reading and writing for PHP 8.3

https://www.liberu.co.uk

MIT License

74 stars 39 forks source link

[Sweep Rules] Refactor large `convert` method in `Writer.php` #28

Closed sweep-ai[bot] closed 6 months ago

sweep-ai[bot] commented 6 months ago

PR Feedback (click)

[ ] 👍 Sweep Did Well
[ ] 👎 Sweep Needs Improvement
I created this PR to address this rule:

"Refactor large functions to be more modular."

Description

This PR refactors the convert method in the Writer.php file to improve readability and maintainability. The method is currently too large and handles the conversion of multiple sections of the GEDCOM file. The refactoring breaks down the method into smaller, more modular methods, each responsible for converting a specific section of the GEDCOM file.

Summary of Changes

Created separate protected methods for each section of the GEDCOM file conversion.
Modified the convert method to call these separate methods for each section.
Updated the WriterTest.php file to test the refactored convert method.

Please review and merge this PR once the changes have been verified.

sweep-ai[bot] commented 6 months ago

Rollback Files For Sweep

[ ] Rollback changes to src/Writer.php
[ ] Rollback changes to src/Writer.php
[ ] Rollback changes to tests/WriterTest.php
[ ] Rollback changes to tests/WriterTest.php