liberu-genealogy / php-gedcom

Gedcom reading and writing for PHP 8.3
https://www.liberu.co.uk
MIT License
74 stars 40 forks source link

Add Unit Tests for New Business Logic and Correct Test Method Calls #33

Closed sweep-ai[bot] closed 2 months ago

sweep-ai[bot] commented 4 months ago

PR Feedback (click)

Summary of Changes

  1. Corrected the method calls from Writer::convertHeadHead to the appropriate method names in the existing tests.
  2. Added comprehensive unit tests for each of the specified methods to ensure they handle all expected inputs and edge cases correctly. This includes:
    • Testing convertSubms with an empty array, a single item, and multiple items.
    • Testing convertSours with an empty array, a single source, and multiple sources, including cases with different formatting options if applicable.

These changes ensure the reliability and robustness of the business logic in src/Writer.php and maintain the quality of our codebase.

sweep-ai[bot] commented 4 months ago

Rollback Files For Sweep