liberu-genealogy / php-gedcom

Gedcom reading and writing for PHP 8.3
https://www.liberu.co.uk
MIT License
74 stars 40 forks source link

Add Unit Tests for DataOptimizer and Sour Classes #37

Closed sweep-ai[bot] closed 4 months ago

sweep-ai[bot] commented 4 months ago

PR Feedback (click)

For the DataOptimizer class, tests have been added for the trimString, normalizeIdentifier, and concatenateWithSeparator methods. These tests cover various inputs, including edge cases like empty strings, strings with only whitespace, and strings with special characters.

For the Sour class, tests have been added for the convert method. This method contains complex logic, so the tests cover different scenarios and edge cases. The tests ensure that the method can handle a wide range of inputs, including cases where certain properties are present, absent, or have unusual values.

Summary of Changes

sweep-ai[bot] commented 4 months ago

Rollback Files For Sweep