[Sweep Rules] Refactor large function in Writer.php - Githubissues

liberu-genealogy / php-gedcom

Gedcom reading and writing for PHP 8.3

https://www.liberu.co.uk

MIT License

74 stars 39 forks source link

[Sweep Rules] Refactor large function in Writer.php #8

Closed sweep-ai[bot] closed 6 months ago

sweep-ai[bot] commented 6 months ago

PR Feedback (click)

[ ] 👍 Sweep Did Well
[ ] 👎 Sweep Needs Improvement
I created this PR to address this rule:

"Refactor large functions to be more modular."

Description

This PR reverts the changes made to the convert method in Writer.php and ensures that any future refactoring follows the guideline of breaking large functions into smaller, more modular functions.

Summary of Changes

Reverted the changes made to the convert method in Writer.php.
Removed the added parameter $format and changed the return type back to string.
Updated the method to perform the necessary conversions based on the properties of the Gedcom object.
Ensured that any future refactoring follows the guideline of breaking large functions into smaller, more modular functions.

Please review and merge this PR. Thank you!

sweep-ai[bot] commented 6 months ago

Rollback Files For Sweep

[ ] Rollback changes to src/Writer.php
[ ] Rollback changes to src/Writer.php