This PR addresses the issue of code modularity. It breaks down large functions into smaller, more manageable pieces that each perform a single task. This makes the code easier to understand, test, and maintain.
Summary of Changes
Created new handler classes TenantLoginHandler, TenantRegisterHandler, TenantVerificationHandler, and TenantResetHandler in app/Filament/Resources/Handlers to handle specific tasks related to tenant authentication.
Refactored TenantResource.php to use the newly created handler classes for login, registration, verification, and password reset.
Refactored AuthController.php to include authentication logic using TenantLoginHandler.
Refactored EventServiceProvider.php to organize event listeners more effectively.
Refactored landlord.php to define routes in a more modular and organized manner.
Refactored ContractorPanelProvider.php and LandlordPanelProvider.php to make the login functionality more modular.
These changes adhere to the principle of modularity, making the codebase more maintainable and testable.
PR Feedback (click)
I created this PR to address this rule:
"Refactor large functions to be more modular."
Description
This PR addresses the issue of code modularity. It breaks down large functions into smaller, more manageable pieces that each perform a single task. This makes the code easier to understand, test, and maintain.
Summary of Changes
TenantLoginHandler
,TenantRegisterHandler
,TenantVerificationHandler
, andTenantResetHandler
inapp/Filament/Resources/Handlers
to handle specific tasks related to tenant authentication.TenantResource.php
to use the newly created handler classes for login, registration, verification, and password reset.AuthController.php
to include authentication logic usingTenantLoginHandler
.EventServiceProvider.php
to organize event listeners more effectively.landlord.php
to define routes in a more modular and organized manner.ContractorPanelProvider.php
andLandlordPanelProvider.php
to make the login functionality more modular.These changes adhere to the principle of modularity, making the codebase more maintainable and testable.