search

libesmtp / libESMTP

Official libESMTP repository.
https://libesmtp.github.io/
GNU Lesser General Public License v2.1
10 stars 7 forks source link

1.1.0: build fails #19

Open kloczek opened 10 months ago

kloczek commented 10 months ago

Looks like something is wrong

Meson output ```console + /usr/bin/meson setup --buildtype=plain --prefix=/usr --libdir=/usr/lib64 --libexecdir=/usr/libexec --bindir=/usr/bin --sbindir=/usr/sbin --includedir=/usr/include --datadir=/usr/share --mandir=/usr/share/man --infodir=/usr/share/info --localedir=/usr/share/locale --sysconfdir=/etc --localstatedir=/var --sharedstatedir=/var/lib --wrap-mode=nodownload --auto-features=enabled . x86_64-redhat-linux-gnu -D bdat=true -D etrn=true -D lwres=disabled -D pthreads=enabled -D tls=enabled -D warning_level=0 -D xdg=true -D xusr=true The Meson build system Version: 1.3.1 Source dir: /home/tkloczko/rpmbuild/BUILD/libESMTP-1.1.0 Build dir: /home/tkloczko/rpmbuild/BUILD/libESMTP-1.1.0/x86_64-redhat-linux-gnu Build type: native build Project name: libESMTP Project version: 1.1.0 C compiler for the host machine: /usr/bin/gcc (gcc 14.0.1 "gcc (GCC) 14.0.1 20240127 (Red Hat 14.0.1-0)") C linker for the host machine: /usr/bin/gcc ld.bfd 2.41-32 Host machine cpu family: x86_64 Host machine cpu: x86_64 Compiler for C supports arguments -D_POSIX_C_SOURCE=200809L: YES Library dl found: YES Found pkg-config: YES (/usr/bin/pkg-config) 2.1.0 Run-time dependency openssl found: YES 3.1.4 Run-time dependency threads found: YES Library lwres skipped: feature lwres disabled Checking for function "strlcpy" : YES Checking for function "strdup" : YES Checking for function "strncasecmp" : YES Checking for function "strcasecmp" : YES Header "string.h" has symbol "memrchr" : NO Checking for size of "unsigned int" : 4 Checking for size of "unsigned long" : 8 Checking for size of "unsigned short" : 2 Configuring config.h using configuration Configuring libesmtp.spec using configuration Build targets in project: 6 libESMTP 1.1.0 current:revision:age: 8:0:2 so version : 6.2.0 prefix : /usr libdir : lib64 threads : true lwres : false AUTH modules : /usr/lib64/modules/libesmtp Legacy file layout : false STARTTLS : true CHUNKING : true ETRN : true XUSR : true User defined options auto_features : enabled bindir : /usr/bin buildtype : plain datadir : /usr/share includedir : /usr/include infodir : /usr/share/info libdir : /usr/lib64 libexecdir : /usr/libexec localedir : /usr/share/locale localstatedir : /var mandir : /usr/share/man prefix : /usr sbindir : /usr/sbin sharedstatedir : /var/lib sysconfdir : /etc warning_level : 0 wrap_mode : nodownload bdat : true etrn : true lwres : disabled pthreads : enabled tls : enabled xdg : true xusr : true Found ninja-1.11.1 at /usr/bin/ninja ```

And ..

build fails with ```console [tkloczko@pers-jacek x86_64-redhat-linux-gnu]$ ninja [1/5] Compiling C object libesmtp.so.6.2.0.p/smtp-api.c.o FAILED: libesmtp.so.6.2.0.p/smtp-api.c.o /usr/bin/gcc -Ilibesmtp.so.6.2.0.p -I. -I.. -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -std=c11 -D_POSIX_C_SOURCE=200809L -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -O2 -g -grecord-gcc-switches -pipe -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdata-sections -ffunction-sections -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -flto=auto -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -Wall -Werror=format-security -fPIC -pthread -MD -MQ libesmtp.so.6.2.0.p/smtp-api.c.o -MF libesmtp.so.6.2.0.p/smtp-api.c.o.d -o libesmtp.so.6.2.0.p/smtp-api.c.o -c ../smtp-api.c ../smtp-api.c: In function ‘smtp_version’: ../smtp-api.c:1183:7: error: implicit declaration of function ‘strlcpy’; did you mean ‘strncpy’? [-Wimplicit-function-declaration] 1183 | if (strlcpy (buf, v, len) > len) | ^~~~~~~ | strncpy [2/5] Compiling C object libesmtp.so.6.2.0.p/smtp-tls.c.o FAILED: libesmtp.so.6.2.0.p/smtp-tls.c.o /usr/bin/gcc -Ilibesmtp.so.6.2.0.p -I. -I.. -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -std=c11 -D_POSIX_C_SOURCE=200809L -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -O2 -g -grecord-gcc-switches -pipe -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdata-sections -ffunction-sections -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -flto=auto -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -Wall -Werror=format-security -fPIC -pthread -MD -MQ libesmtp.so.6.2.0.p/smtp-tls.c.o -MF libesmtp.so.6.2.0.p/smtp-tls.c.o.d -o libesmtp.so.6.2.0.p/smtp-tls.c.o -c ../smtp-tls.c ../smtp-tls.c: In function ‘check_acceptable_security’: ../smtp-tls.c:580:21: error: implicit declaration of function ‘strlcpy’; did you mean ‘strncpy’? [-Wimplicit-function-declaration] 580 | strlcpy (buf, ia5str, sizeof buf); | ^~~~~~~ | strncpy ninja: build stopped: subcommand failed. ```
kloczek commented 10 months ago

Just found that issue is already fixed on master. As on master is fixed as well openssl mem leak and fact that last release was almost 3 years ago I think that it would be good to flush all those commits and release new version.