search

libffcv / ffcv

FFCV: Fast Forward Computer Vision (and other ML workloads!)
https://ffcv.io
Apache License 2.0
2.82k stars 178 forks source link

Git tag for v0.0.3 #158

Closed samuela closed 2 years ago

samuela commented 2 years ago

I see that there's a release tagged for v0.0.3rc1, but no tag for release v0.0.3 which is currently that latest release on pypi. Would it be possible to get a git tag for v0.0.3?

Having git tags for releases makes it a lot easier for others to package ffcv, eg in Nixpkgs.

GuillaumeLeclerc commented 2 years ago

Sure!

samuela commented 2 years ago

Thanks @GuillaumeLeclerc !

samuela commented 2 years ago

Huh for some reason the download is not working for me. Opening https://github.com/libffcv/ffcv/archive/v0.0.3.tar.gz gives me

the given path has multiple possibilities: #<Git::Ref:0x00007f5296528a88>, #<Git::Ref:0x00007f529652f748>

I've never seen this before...

samuela commented 2 years ago

Perhaps the git tag was created with a SHA prefix that is not unique within this repo?

GuillaumeLeclerc commented 2 years ago

Whoa that would be extremely unlikely. No idea how to fix it :(

GuillaumeLeclerc commented 2 years ago

https://github.com/libffcv/ffcv/archive/refs/tags/v0.0.3.tar.gz works for me.

samuela commented 2 years ago

Unfortunately I'm working with existing automation that hits the https://github.com/libffcv/ffcv/archive/v0.0.3.tar.gz endpoint whether I like it or not.

I have a workaround for the time being, but it's an interesting failure I'd never seen before.

GuillaumeLeclerc commented 2 years ago

The weird thing is that if you refresh the page you get a different hash. Maybe worth reporting to github ?

samuela commented 2 years ago

Oh that is very odd! I hadn't noticed that the hashes change!

samuela commented 2 years ago

Btw I'm working on getting FFCV packaged in nixpkgs: https://github.com/NixOS/nixpkgs/pull/160441 which is how I ended up on this...

GuillaumeLeclerc commented 2 years ago

Looks cool! Thanks for integrating FFCV

GuillaumeLeclerc commented 2 years ago

(I hope you are not spending too much time on v0.0.3 as I hope to release v1.0.0-rc1 before the end of the week.)

samuela commented 2 years ago

ooh, exciting! shouldn't be a problem unless there are significant changes to the dependencies or build system

GuillaumeLeclerc commented 2 years ago

No just adding new features