search

libffcv / ffcv

FFCV: Fast Forward Computer Vision (and other ML workloads!)
https://ffcv.io
Apache License 2.0
2.81k stars 180 forks source link

dependency "sklearn" should be "scikit-learn" #169

Closed tfriedel closed 2 years ago

tfriedel commented 2 years ago

https://github.com/libffcv/ffcv/blob/89dc2fabd59f85aab5826b294bc0d34eb236cea4/setup.py#L55

simply replace it. sklearn does install some package, but not the one we want.

andrewilyas commented 2 years ago

From what I can tell, we actually don't use scikit-learn anywhere, so it might be safe to just delete this line?

andrewilyas commented 2 years ago

Closing as a duplicate of #159