search

libffcv / ffcv

FFCV: Fast Forward Computer Vision (and other ML workloads!)
https://ffcv.io
Apache License 2.0
2.81k stars 180 forks source link

Look for package opencv.pc if opencv4.pc is not found #187

Closed dskhudia closed 1 year ago

dskhudia commented 2 years ago

Conda env creates opencv4.pc (used by pkg-config) while apt install libopencv-dev creates opencv.pc.

See https://github.com/libffcv/ffcv/issues/182 for more details.

GuillaumeLeclerc commented 2 years ago

This looks good! Do you mind fixing the merge conflict so that I can add it to v1.0.0 ?

dskhudia commented 2 years ago

This looks good! Do you mind fixing the merge conflict so that I can add it to v1.0.0 ? @GuillaumeLeclerc

Thanks. Just updated.

andrewilyas commented 1 year ago

@dskhudia Sorry for the delay on this, but should line 96 in setup.py here be inside the except?