Update sklearn to scikit-learn

libffcv / ffcv

FFCV: Fast Forward Computer Vision (and other ML workloads!)

https://ffcv.io

Apache License 2.0

2.79k stars 180 forks source link

Update sklearn to scikit-learn #275

Closed mvpatel2000 closed 1 year ago

mvpatel2000 commented 1 year ago

Closes https://github.com/libffcv/ffcv/issues/274. Current method is deprecated

mvpatel2000 commented 1 year ago

@andrewilyas for review

andrewilyas commented 1 year ago

Thanks for doing this! I think maybe we should merge into the v1.0 branch instead of main? (@GuillaumeLeclerc) That way we can merge that into main soon and update on PyPI.

mvpatel2000 commented 1 year ago

It looks like there's more in 1 vs. main. Please let me know if I should change target and rebase, or feel free to push the change since its 1 line yourself.

andrewilyas commented 1 year ago

Sounds good, I'll merge it and then we can merge it into 1.0 later since it's such a small fix. Thanks!