libffcv / ffcv

FFCV: Fast Forward Computer Vision (and other ML workloads!)
https://ffcv.io
Apache License 2.0
2.84k stars 178 forks source link

Small bug (improvement suggestion) in the quickstart doc #348

Closed jnboehm closed 1 year ago

jnboehm commented 1 year ago

Reading through the quickstart, the variable jpeg_quality is not defined explicitly. Since the RGBField uses the raw write mode in that example (as it's the default), I think it'd make more sense to remove the jpeg_quality argument from the code snippet to make things easier to grasp at the beginning.

andrewilyas commented 1 year ago

Fixed! https://github.com/libffcv/ffcv/commit/6c3be0cabf1485aa2b6945769dbd1c2d12e8faa7