libfn / functional

Extending C++ library for functional programming
ISC License
60 stars 8 forks source link

Add pre-commit support, and fix end of line and file issues #120

Open Twon opened 20 hours ago

Twon commented 20 hours ago

Adds support for pre-commit originally proposed in https://github.com/libfn/functional/pull/117, moved here due to the issues encountered with the merge against the rewritten history on main.

codecov[bot] commented 20 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.0%. Comparing base (89ed034) to head (371223a).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/libfn/functional/pull/120/graphs/tree.svg?width=650&height=150&src=pr&token=3RHT38SEU0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libfn)](https://app.codecov.io/gh/libfn/functional/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libfn) ```diff @@ Coverage Diff @@ ## main #120 +/- ## ======================================= Coverage 100.0% 100.0% ======================================= Files 20 20 Lines 858 858 Branches 121 121 ======================================= Hits 858 858 ``` [![Impacted file tree graph](https://app.codecov.io/gh/libfn/functional/pull/120/graphs/tree.svg?width=650&height=150&src=pr&token=3RHT38SEU0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libfn)](https://app.codecov.io/gh/libfn/functional/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libfn)
Twon commented 7 hours ago

Thank you a lot for this change, also for cleaning up both line and file endings.

Several small comments; also sorry for making the main branch unstable today 😿

You're welcome. I've addressed the PR comments. Please let me know if there is anything else and I will address it.

Bronek commented 5 hours ago

T

Thank you a lot for this change, also for cleaning up both line and file endings. Several small comments; also sorry for making the main branch unstable today 😿

You're welcome. I've addressed the PR comments. Please let me know if there is anything else and I will address it.

Thank you ! Before I merge it, I need commits to be signed. https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits