search

libgdx / box2dlights

Fork of box2dlights by Kalle Hamalainen
Apache License 2.0
257 stars 82 forks source link

Whitespacing issue #121

Closed kdenzel closed 3 years ago

kdenzel commented 3 years ago

Hello, i got a huge Problem with whitespacing. I made a fork from this repository and tried to create PR for the master branch but i can't get rid of whitespacing issues. I am on a windows machine with core.autocrlf=true, this means every time i add or change a file it will replace every crlf with an lf when i commit changes and when i checkout it will convert lf to crlf. This is per default the convention when working on a windows machine on a repo with the world.

Tried to fix it with tools like dos2unix and unix2dos but it did not fix it. Sure, i can compare the repos with the swith w=1 in the URL, but i want to make a clean PR.

Now i looked at the files in the master branch and what caught my eye was that your files are sometimes crlf and sometimes lf. For example your pom file is crlf (you can check that with the command file pom.xml on gitbash for example).

SimonIT commented 3 years ago

You can disable it inside the libgdx directory with git config core.autocrlf false. That's also what I'm doing to prevent messing with the line endings. We are aware of this problem