search

libgdx / gdx-liftoff

A modern setup tool for libGDX Gradle projects
Apache License 2.0
524 stars 48 forks source link

Fix cyclic dependency #153

Closed cartesian-plane closed 4 months ago

cartesian-plane commented 4 months ago

Fixes issue #149

Warns the user about having "Game" as a class name. It's not the cleanest way, but it should hopefully prevent future accidents.

Frosty-J commented 4 months ago

Perhaps an atypical thing to do, but if you ever want to merge multiple projects into one at a later date, I found having a generic name for the main class makes doing so more difficult.

tommyettinger commented 4 months ago

I believe the fix in the latest commit resolves this in a different way. It doesn't use a generic name, so I hope that works for you, @Frosty-J , and instead validates against every (non-inner) type name defined by the core of libGDX. I could maybe expand it to the whole JDK, and/or the Kotlin standard library, but that's pushing it. Thanks for the PR, but I'll close this now.