libgdx / gdx-particle-editor

The official particle editor for libGDX.
Apache License 2.0
35 stars 5 forks source link

1.0.1 issues #2

Closed NathanSweet closed 7 months ago

NathanSweet commented 7 months ago

Hola! I thought it'd be better to post here rather than there.

I took 1.0.1 for a quick spin:

raeleus commented 7 months ago

Thank you very much for following up on this. I suspect that you have a driver/hardware issue with your mouse that causes it to send two touch-downs instead of just one. You can test that here if you're interested. You should get 0 "Double Clicks" with a normally functioning mouse. Nevertheless, it's a good idea to harden the widgets against this sort of thing anyway. Can you try the attached updated JAR? It should solve these issues. gdx-particle-editor.zip And thanks for noticing the drag bars. I took inspiration from Spine on that one 😉

NathanSweet commented 7 months ago

How DARE you suggest my wonderful mouse has a malfunction!? I'd surely have noticed in Spine development. Clicking normally on that test page I get 0 double clicks.

You zipped a JAR? :p Trying that JAR:

raeleus commented 7 months ago

Sorry, Nate. I'm totally at a loss on this one. I only mentioned the double click thing because I had that problem with an old mouse. Maybe I have to buy one of those trackballs to see what's going on. Perhaps this was all a ruse to get me to see the light ehh? I feel like I have to refactor these classes completely. I'll give it another try this weekend. It's just so perplexing to me. It's only touch downs and touch ups. Thanks again.

NathanSweet commented 7 months ago

As much as I love the trackball (it has a scroll ring around the ball! a ball ring, if you will) I doubt it's hardware specific. I can't explain why you can't repro, except possibly that with an old fashioned arthritic mouse it's easy to move 1px and wreck the repro.

I see the InputListener returns false in touchDown. Per the javadoc, true must be returned for touchUp to be called. If false is returned, the actor is not added to the Stage's touchFocuses and will never receive a touchUp.

raeleus commented 7 months ago

Ahh, what a rookie mistake. That would explain the behavior in Spinner, but not in ColorGraph and LineGraph. I'll do some more testing.

raeleus commented 7 months ago

@NathanSweet, sorry to keep bugging you. I think I've addressed the new issues you pointed out in 1.0.2. I should buy you a beer or something :-)

NathanSweet commented 7 months ago

Nah, I'm happy to help. I've confirmed everything looks good now! \o/