#198 added synchronized block to instantiation and strong-ref management

libgdx / gdx-pay

A libGDX cross-platform API for InApp purchasing.

Apache License 2.0

224 stars 83 forks source link

#198 added synchronized block to instantiation and strong-ref management #200

Closed keesvandieren closed 5 years ago

keesvandieren commented 5 years ago

Hi @MrStahlfelge , I think we need to synchronize instantiation and strongref management.

I was not able to reproduce the problem (as it happens only for 1-2% of our users), but based on reasoning of code, I think this patch may solve the problem.

Can you review the PR? Thanks in advance.

MrStahlfelge commented 5 years ago

Yes it could be a solution. Do you want to test this on an own build before merging to master?

keesvandieren commented 5 years ago

I’ve verified that the app launches without problems.

I will run a test for a week, and see if it solves the crash, if we want to be really sure it helps?

MrStahlfelge commented 5 years ago

That's a good plan, let's do it this way. Please comment again then. :)

MrStahlfelge commented 5 years ago

Closing it because it doesn't fix #198