Closed FStranieri closed 4 years ago
Hi,
Thanks for your contribution! Can you please provide following updates:
Hi,
Thanks for your contribution! Can you please provide following updates:
- look at codebeat issues, and solve their reported issues if appropriate.
- provide a README.md with instructions how to use it.
Done! For the codebeat issues I've operated some changes.
Thank you!
Hi, thanks for the contribution.
Code looks good to me.
Unfortunately, I can't test it because I don't have an Huawei account, so I'd just want to ask if you have tested the implementation against our example application project. This is important to see if there are any quirks in the implementation that are hidden by your own game project.
Hi, thanks for the contribution.
Code looks good to me.
Unfortunately, I can't test it because I don't have an Huawei account, so I'd just want to ask if you have tested the implementation against our example application project. This is important to see if there are any quirks in the implementation that are hidden by your own game project.
Hi, thanks for the suggestion! I've forked the gdx-pay-app and added a test for HuaweiPurchaseManager link. I've discovered 3 regressions caused to the enhancement for codebeats. It works with all tests included into the app (install, productInfo, purchase of entitlement and consumable (i support subscription too) and the restore).
Screens:
Thanks! @keesvandieren do you see any reason not to merge this?
I think it is fine to merge this 👍🏼
Hartelijke groeten,
Kees van Dieren Oranjestraat 30 2983HS Ridderkerk 📞+31 (0) 6-30413841
Op di 12 mei 2020 17:57 schreef Benjamin Schulte notifications@github.com:
Thanks! @keesvandieren https://github.com/keesvandieren do you see any reason not to merge this?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libgdx/gdx-pay/pull/215#issuecomment-627434417, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGS5XUPQWBLZ4KPFMCGDJTRRFWYLANCNFSM4M43K2IA .
Thank you! What about the artifact on maven central? Thanks.
Regards, Francesco Stranieri
1.2-SNAPSHOT is updated, tell me if there's a problem
It works! Thanks.
Hi, are you planning a new stable release? @MrStahlfelge @keesvandieren Thank you
Yes it is needed because of the Google Play change too. @keesvandieren do you already use the snapshot in production?
I'm using version 1.1.0 of gdx-pay-android-googlebilling, and that version is working fine for our project. We are using subscriptions.
What is the change needed on Google Play? Is Google Billing 1.x going end of life?
Yes, April 2021 is the switch-off of 1.x and AIDL
Aha ok. Currently it is a bit dangerous to try things out on Google Play. Currently app-updates take about one week:
I prefer to try it out, when Google app-updates scheme is 'back to normal'. Hopefully coming soon, as covid-19 is calming down a bit?
Has anybody else already tried it out?
I use it in a non-libgdx app without gdx-pay in the same way it is implemented here, so I am expecting no problems.
As far as I am concerned, Google Play wait times are back to normal. Google Billing 3.0.0 is already out, so I think we should make a new release soon.
Releasing is fine to me as well now.
We're using snapshot as of now, and it seems to work well.
We're considering to add more features (related to subscriptions), but that can also be added to a subsequent release, as it may take time.
Release is done. :-)
This is a new PurchaseManager to manage the HUAWEI App Gallery purchases. It checks if the app environment is ready to manage those kind of purchases and then it fetch all pricetypes (consumable, entitlement and subscriptions). It also provides a public method to consume a consumable product. With this manager, the developer has to implement the callbacks and manage the results. It's very easy to integrate.
Thank you.
Regards, Francesco Stranieri