libgdx / gdx-pay

A libGDX cross-platform API for InApp purchasing.
Apache License 2.0
225 stars 83 forks source link

Upgrade gradle #248

Closed SimonIT closed 1 year ago

SimonIT commented 1 year ago

I tested it with publishToMavenLocal and it seems to work fine

SimonIT commented 1 year ago

@bitdream

Is upgrading Gradle really necessary? Java 11 is not compatible with Java 8! This is a big update.

Java 11 is only required if you want to build gdx-pay itself. You can still use Java 8 in your own project. Why is it a big deal with requiring Java 11? You can run your own Java 8 code also on Java 11, so I don't see the problem... Gradle updating is required to support the newest JDKs. You need at least gradle 7.5 to use Java 18

bitdream commented 1 year ago

@bitdream

Is upgrading Gradle really necessary? Java 11 is not compatible with Java 8! This is a big update.

Java 11 is only required if you want to build gdx-pay itself. You can still use Java 8 in your own project. Why is it a big deal with requiring Java 11? You can run your own Java 8 code also on Java 11, so I don't see the problem... Gradle updating is required to support the newest JDKs. You need at least gradle 7.5 to use Java 18

Glad to know only building the lib affected. Then it's totally fine. There are known issues with ByteBuffer when updating from Java 8 to higher version.