search

libgdx / gdx-video

A libGDX cross platform video rendering extension
Apache License 2.0
147 stars 48 forks source link

Update world dimensions after loading player #20

Closed jameelur closed 8 years ago

jameelur commented 8 years ago

The current VideoPlayerAndroid does not adhere to the viewport type that was used in it's instantiation. The changes I've made updates the viewport world dimensions once the media player has been prepared and then update the viewport and camera to display the video in the correct dimensions.

RBogie commented 8 years ago

I'll look into the changes tonight, after which I'll probably merge it. Thank you for the contribution!

RBogie commented 8 years ago

Indeed the documentation says that it will set the world size to the video size, and the android implementation didn't do this. However, the desktop implementation also does not do this.

Since I'm quite busy at the moment, could you add this as well? Could you also fix the indentation?

jameelur commented 8 years ago

I'm not quite familiar with the desktop implementation as I haven't tried it out before. So it may be better if you could make that change when you can. But from what I can see, you do set the viewport world size to the video dimensions (line 173).

I've fixed the indentation as requested. My mistake, didn't notice you use tabs instead of whitespace.

RBogie commented 8 years ago

Ow yeah, you're right. I totally missed that line. Thank you for the fixes!