search

libgdx / gdx-video

A libGDX cross platform video rendering extension
Apache License 2.0
145 stars 50 forks source link

Update VideoActor to set the batch color before drawing the video texture #91

Closed lucas-kakele closed 2 months ago

lucas-kakele commented 3 months ago

Setting the batch color before drawing the video texture prevents other actors in the stage that modifies the batch color from tinting the video texture.

lucas-kakele commented 2 months ago

Hi folks. Are there any extra steps I should follow for the PR to be reviewed? Thanks!

SimonIT commented 2 months ago

Hi, no, there aren't any extra steps. My hope was to get some reviews from some of the other contributors about whether this change makes sense, as I'm not very familiar with scene2d. I also had the hope to being able to fox the CI, but I have no clue why this error appears

SimonIT commented 2 months ago

I got a quick look from @lyze237; looks good