search

libgenapps / LibgenDesktop

1.79k stars 214 forks source link

Importing fiction dump from after 2020-02-08 fails on 1.3.5 #19

Closed RedKage closed 4 years ago

RedKage commented 4 years ago

Hello there,

Here is the fiction dump http://gen.lib.rus.ec/dbdumps/fiction_2020-02-17.rar with extracts to fiction.sql with Size: 2368562429 bytes (2258 MiB) and CRC32: A2E42C88.

On a clean install with no database, I select import, then I select fiction.sql and at the end I get Screenshot_1

The logs don't give much info 2020-02-19_11-07-58.log

RedKage commented 4 years ago

Hmmm, this dump http://gen.lib.rus.ec/dbdumps/fiction_2020-01-11.rar does import fine I guess something changed between fiction_2020-01-11 and fiction_2020-02-17

RedKage commented 4 years ago

Alright so I narrowed it down, the last working fiction dump is the one from 2020-02-08. Anything after that cannot be imported. Guess the database schema changed or something

libgenapps commented 4 years ago

Yes, there has been a database change on the server side on February 12 that affected this particular collection. I'll add the support for the new database dump format in the upcoming version.

smaragdus commented 4 years ago

I got the same error when I try to import from fiction_2020-02-25.rar:

Couldn't find the data to import.

screen:

Libgen Desktop 1 3 5 - 2020-02-26 - error - 001

I hope that a fixed version will be released soon since for the time being Libgen Desktop is unusable for me. By the way I discovered the program today and I am glad that it is really portable (configuration and data files saved in program folder).

libgenapps commented 4 years ago

@smaragdus, right, sorry about that. The last database dump supported by the current version of LibgenDesktop is fiction_2020-02-08.rar. I will try to release the fix by the end of the next week.

smaragdus commented 4 years ago

@libgenapps

Thank you for clarifying which is the last supported dump. Take your time, I am not in a hurry. Actually I am glad that you still maintain Libgen Desktop.

libgenapps commented 4 years ago

Due to some unforeseen circumstances I won't be able to release the new version today. The new estimate is the end of the next week.

libgenapps commented 4 years ago

Looks like I won't be able release it this week either. I'll do my best to release it around the beginning of April.

ekescs commented 4 years ago

Hi, do you have any luck with the new release? Thanks for your efforts :) Stay safe :)

libgenapps commented 4 years ago

Sorry for the delay. The last couple months have been kinda erratic.

Support for the new fiction database dump format is completed, I just need to wrap up implementation for a few other features. The release will probably be somewhere around the end of the next week.

Elpuma commented 4 years ago

i was able to fix the issue by correcting the GET {link} structure. I'm new in Github, how do I share my code? should I paste it here or elsewhere? My database is 46GB big so far and it works perfectly.

RedKage commented 4 years ago

Usually you do this by creating a pull request. Then, the owner can check your code and decide to reintegrate your branch into the main code.

However from what I understand, libgenapp has already an unpunished fix for this. But, it's still useful to make a PR in my opinion as you may have done things differently than libgenapp

From: Jose Rodriguez notifications@github.com Sent: Sunday, May 3, 2020 2:12 AM To: libgenapps/LibgenDesktop Cc: TacticalFreak; Author Subject: Re: [libgenapps/LibgenDesktop] Importing fiction dump from after 2020-02-08 fails on 1.3.5 (#19)

i was able to fix the issue by correcting the GET {link} structure. I'm new in Github, how do I share my code? should I paste it here or elsewhere?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

libgenapps commented 4 years ago

Implemented in 1.4.0.