search

libgenapps / LibgenDesktop

1.83k stars 219 forks source link

Filter by language #25

Open fabianski7 opened 4 years ago

fabianski7 commented 4 years ago

I read that you are preparing major changes in version 1.4.0 and would like to suggest that an option be added to filter by book language. That would be very welcome.

libgenapps commented 4 years ago

I will definitely not be able to implement filtering / advanced search in time for the 1.4.0 release but I am planning to add the Language column in the search results.

libgenapps commented 4 years ago

Language column has been added in 1.4.0.

dynuel commented 3 years ago

is there any way to do advanced search by the language and other parameters?

UnlimitedChild commented 3 years ago

Please add a language filter in the search, an extremely necessary function.

grv87 commented 2 years ago

@UnlimitedChild, I'll answer here. This project requires a maintainer experienced in C# which I'm not. See discussion in #39. Until there is one, my help is a waste of time.

grv87 commented 2 years ago

As for the feature, why do you need this filter? As I pointed out in https://github.com/libgenapps/LibgenDesktop/issues/27#issuecomment-1021820919, it's expected that you search for a book in a book recommendation service. And only when you know what you want (title, ISBN) then you search for it in the Libgen. So, this feature would allow using Libgen as a primary catalog of books. Which is not, never were and never will be. This feature would promote bad behavior and would confuse all future users about what Libgen is and what it's not.

On the other hand, this feature is not so easy as you think. Libgen doesn't use a predefined list of languages: image How do expect searching by selected language should work? Should a user (each time he performs a search) select a dozen of variants by hand? Or should the app have some known 'aliases'? And who should keep and update the list of those aliases? Or …?

The simple solution would not be convenient to use, and the good solution would require a lot of code. It's a complication, and each complication should be justified. Or software will become expensive/impossible to maintain — as you can already see here.

Considering all this, if it was my software, I'd never implemented this feature.

But if you still want to perform non-standard search — I don't see a problem. The app's database is in SQLite format. Open it with something like DB Browser and search what you want with any filters you want. Right now, there is no need to add any features in LibgenDesktop.

imsys commented 1 year ago

I would suggest something like libreoffice does when we use the filter option. After we do the search, we can filter the results.

But I would mostly want this on the website, instead of the software, so I could send the URL containing the desired books to people who doesn't understand english well. For me it would not even need a fancy UI, if I could just add to the URL something like: "&language=Spanish,Portuguese,es,pt,pt-br,pt-pt", would already be helpful.

filter-language