Some mirrors always show the same error - nonfiction returned an invalid URL

UnlimitedChild commented 3 years ago

Hi,

some mirrors always show the same error, but the browser downloads this link well.

[01:07:10 PM] Stopped. [08:20:26 AM] Added to the download queue. [08:20:26 AM] Started. [08:20:26 AM] Downloading page: http://libgen.lc/ads.php?md5=067B35724BDF1DE6FB44E53F80840CA5 [08:20:26 AM] Request: GET http://libgen.lc/ads.php?md5=067B35724BDF1DE6FB44E53F80840CA5 User-Agent: LibgenDesktop/1.4.1 [08:20:27 AM] Server response: 200 OK Connection: keep-alive Vary: Accept-Encoding, Accept-Encoding Date: Thu, 29 Apr 2021 06:22:30 GMT Server: nginx Content-Length: 4146 Content-Type: text/html [08:20:27 AM] Transformation libgen_lc_nonfiction returned an invalid URL.

Regards,

geek-mr-xie commented 3 years ago

I have the same problem. Please Help XD

geek-mr-xie commented 3 years ago

You can use http://gen.lib.rus.ec/ to download, but it is too slow.

UnlimitedChild commented 3 years ago

You can use http://gen.lib.rus.ec/ to download, but it is too slow.

Hi,

after changing the mirror, my link doesn't change, so I can't change anything.

UnlimitedChild commented 3 years ago

Download doesn't work on any server now..

[11:08:30 PM] Added to the download queue. [11:08:30 PM] Started. [11:08:30 PM] Downloading page: http://gen.lib.rus.ec/ads.php?md5=09b49b0c3cffdb8a9058f278361f17fe [11:08:30 PM] Request: GET http://gen.lib.rus.ec/ads.php?md5=09b49b0c3cffdb8a9058f278361f17fe User-Agent: LibgenDesktop/1.4.1 [11:08:34 PM] Server response: 301 MovedPermanently Connection: keep-alive Date: Sun, 09 May 2021 21:08:31 GMT Location: http://libgen.rs/ads.php?md5=09b49b0c3cffdb8a9058f278361f17fe Server: nginx Content-Length: 178 Content-Type: text/html [11:08:34 PM] Redirect to http://libgen.rs/ads.php?md5=09b49b0c3cffdb8a9058f278361f17fe [11:08:34 PM] Request: GET http://libgen.rs/ads.php?md5=09b49b0c3cffdb8a9058f278361f17fe User-Agent: LibgenDesktop/1.4.1 [11:08:34 PM] Server response: 301 MovedPermanently Connection: keep-alive Date: Sun, 09 May 2021 21:08:32 GMT Location: http://library.lol/main/09b49b0c3cffdb8a9058f278361f17fe Server: nginx Content-Length: 178 Content-Type: text/html [11:08:34 PM] Redirect to http://library.lol/main/09b49b0c3cffdb8a9058f278361f17fe [11:08:34 PM] Request: GET http://library.lol/main/09b49b0c3cffdb8a9058f278361f17fe User-Agent: LibgenDesktop/1.4.1 [11:08:34 PM] Server response: 200 OK Transfer-Encoding: chunked Connection: keep-alive Date: Sun, 09 May 2021 21:08:32 GMT Server: nginx Content-Type: text/html; charset=UTF-8 [11:08:34 PM] Transformation libgen_lc_nonfiction returned an invalid URL.

officialsuyogdixit commented 3 years ago

Download doesn't work on any server now..

JulianSMoore commented 3 years ago

Same basic problem here on Win 10, 64-bit, 20H2: invalid URL on all mirrors (non-fiction and scientific articles), despite re-creation of portable setup from June 2021 zip file and fresh databases. Downloads via browser work fine (so no obvious DNS issue)

JulianSMoore commented 3 years ago

Same basic problem here on Win 10, 64-bit, 20H2: invalid URL on all mirrors (non-fiction and scientific articles), despite re-creation of portable setup from June 2021 zip file and fresh databases. Downloads via browser work fine (so no obvious DNS issue)

Part of the problem was failing to see the message here about the separate mirrors update file.

However, whilst non-fiction now works, none of the scientific article sources work - either there is an invalid URL or a timeout.

It would be much appreciated if one knew where to look for definitive answers on what is or is not working, and how to resolve such issues.

UnlimitedChild commented 3 years ago

Same basic problem here on Win 10, 64-bit, 20H2: invalid URL on all mirrors (non-fiction and scientific articles), despite re-creation of portable setup from June 2021 zip file and fresh databases. Downloads via browser work fine (so no obvious DNS issue)

Part of the problem was failing to see the message here about the separate mirrors update file.

However, whilst non-fiction now works, none of the scientific article sources work - either there is an invalid URL or a timeout.

It would be much appreciated if one knew where to look for definitive answers on what is or is not working, and how to resolve such issues.

[04:36:34 PM] Added to the download queue. [04:36:34 PM] Started. [04:36:34 PM] Downloading page: http://libgen.lc/ads.php?md5=A349201D0017CD456E3F4EE20DC22C58 [04:36:34 PM] Request: GET http://libgen.lc/ads.php?md5=A349201D0017CD456E3F4EE20DC22C58 User-Agent: LibgenDesktop/1.4.1 [04:36:36 PM] Server response: 200 OK Connection: keep-alive Vary: Accept-Encoding, Accept-Encoding Date: Sun, 25 Jul 2021 14:36:36 GMT Server: nginx Content-Length: 3513 Content-Type: text/html [04:36:36 PM] Transformation libgen_lc_nonfiction returned an invalid URL.

Nothing works with new mirrors either .. the problem is not in the mirrors.

grv87 commented 3 years ago

libgen.lc doesn't work because it returns relative URL now but Libgen Desktop expects absolute one.

The quick fix (can be made by user) is to change 5th line in file %ProgramFiles%\Libgen Desktop\Mirrors\libgen_lc_nonfiction.xslt to:

      <xsl:text>http://libgen.lc</xsl:text><xsl:value-of select="@href" />

I didn't try another mirrors but I suspect they have the same problem.

Correct fix, IMO, should be done in Libgen Desktop. But I'm not sure which one - the code handles URLs as plain strings which is somewhat incorrect and can't be easily fixed.

grv87 commented 3 years ago

And here are working configurations for library.lol, including IPFS.

(non-fiction only)

UPD: Some URLs from library.lol still don't work.

I hit it on filename containing both non-Latin characters and parentheses. Uri.IsWellFormedUriString returns false. Probably dotnet/runtime#21626.

UnlimitedChild commented 3 years ago

[11:17:33 PM] Started. [11:17:34 PM] Downloading page: http://libgen.lc/ads.php?md5=1287AF2A3E5D379A78CCB5B5C450FD85 [11:17:34 PM] Request: GET http://libgen.lc/ads.php?md5=1287AF2A3E5D379A78CCB5B5C450FD85 User-Agent: LibgenDesktop/1.4.1 [11:17:37 PM] Server response: 200 OK Connection: keep-alive Vary: Accept-Encoding, Accept-Encoding Upgrade: h2, h2c Date: Fri, 03 Sep 2021 21:17:35 GMT Server: nginx Content-Length: 6420 Content-Type: text/html; charset=UTF-8 [11:17:37 PM] Downloading file: http://libgen.lcget.php/?md5=1287af2a3e5d379a78ccb5b5c450fd85&key=9BFYSF04PAJAE5YX [11:17:37 PM] Request: GET http://libgen.lcget.php/?md5=1287af2a3e5d379a78ccb5b5c450fd85&key=9BFYSF04PAJAE5YX User-Agent: LibgenDesktop/1.4.1 Referer: http://libgen.lc/ads.php?md5=1287AF2A3E5D379A78CCB5B5C450FD85 [11:17:48 PM] An unexpected error occurred: The remote name could not be resolved: 'libgen.lcget.php'

UnlimitedChild commented 3 years ago

[11:53:18 PM] Started. [11:53:18 PM] Downloading page: http://libgen.lol/ads.php?md5=965F2DA310AED12DD0D5924AA7412826 [11:53:18 PM] Request: GET http://libgen.lol/ads.php?md5=965F2DA310AED12DD0D5924AA7412826 User-Agent: LibgenDesktop/1.4.1 [11:53:18 PM] Server response: 302 Redirect Connection: close Date: Fri, 03 Sep 2021 21:53:17 GMT Location: http://ww6.libgen.lol/ads.php?md5=965F2DA310AED12DD0D5924AA7412826 Set-Cookie: tad=1630705997.3450095; expires=Mon, 01-Sep-2031 21:53:17 GMT; Max-Age=315360000 Server: Apache/2.4.25 (Debian) Content-Length: 0 Content-Type: text/html; charset=UTF-8 [11:53:18 PM] Redirect to http://ww6.libgen.lol/ads.php?md5=965F2DA310AED12DD0D5924AA7412826 [11:53:18 PM] Request: GET http://ww6.libgen.lol/ads.php?md5=965F2DA310AED12DD0D5924AA7412826 User-Agent: LibgenDesktop/1.4.1 Cookie: tad=1630705997.3450095 [11:53:18 PM] Server response: 200 OK X-Adblock-Key: MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBAJRmzcpTevQqkWn6dJuX/N/Hxl7YxbOwy8+73ijqYSQEN+WGxrruAKtZtliWC86+ewQ0msW1W8psOFL/b00zWqsCAwEAAQ_I++HQaQ0RZuNCopi1YpmJFkKgA4holN+d7XwSg+08uYefKlIDm3HJEnsh3e7DDlQgOHF6raCcFryKX2qh7KMrA Date: Fri, 03 Sep 2021 21:53:17 GMT ETag: "61242ae9-9da" Set-Cookie: caf_ipaddr=178.239.165.170;Path=/;Max-Age=86400;, country=GB;Path=/;Max-Age=86400;, city="Chelsea";Path=/;Max-Age=86400;, expiry_partner=;Path=/;Max-Age=86400; Server: openresty Accept-Ranges: bytes Via: 1.1 google Content-Length: 2522 Content-Type: text/html Last-Modified: Mon, 23 Aug 2021 23:10:33 GMT [11:53:18 PM] Transformation libgen_lc_nonfiction returned an invalid URL.

DarkGhost7 commented 2 years ago

And here are working configurations for library.lol, including IPFS.

(non-fiction only)

UPD: Some URLs from library.lol still don't work.

I hit it on filename containing both non-Latin characters and parentheses. Uri.IsWellFormedUriString returns false. Probably dotnet/runtime#21626.

@grv87 can you compile your fork and make a release version, so it's easier to download and run for users. Since it seems to be the only working fork as far as I can tell atm. Would love to be able to use the desktop app again.

grv87 commented 2 years ago

@DarkGhost7, it looks like I never finished my fork.

it seems to be the only working fork as far as I can tell

And can you compile it? I don't think it's compilable.

I could finish my work into a PR for code review. But I won't be able to maintain a whole fork by myself. C# is not my language. This peace of software is a bad code that requires complete review and rewriting. For example, note the complete lack of testing. And I don't see a single experienced and willing C# developer here. This is why I stopped.

If it was me, I'd rewrite this software from scratch and in a different language. It'd also solve #47. And, if I was rewriting from scratch, I'd also reconsider the position of Libgen client in the whole book (or information) management process. I'm not sure that GUI app is the most efficient tool in 2022. (But I'm not sure that local server proposed in #27 is the most efficient tool either).

Right now, I personally use original binaries with just mirror files changed. If it's useful for somebody, I uploaded https://github.com/grv87/LibgenDesktop/releases/tag/v1.4.1+fixed_mirrors.

DarkGhost7 commented 2 years ago

@grv87 I see sad to see I like this software but am not a very good coder so cannot rewrite and fix it sadly. Thanks for your reply

DarkGhost7 commented 2 years ago

Release works great thanks

DarkGhost7 commented 2 years ago

@UnlimitedChild should work now on the release above