libgit2 / git2go

Git to Go; bindings for libgit2. Like McDonald's but tastier.
MIT License
1.93k stars 316 forks source link

Set BasicAuth in http.go only if username and password are not empty #914

Closed clns closed 2 years ago

clns commented 2 years ago

This prevents error "read/write on closed pipe".

Go's http.client::send() always closes req.Body, so if the first request attempt is unsuccessful, any subsequent requests after calling the CredentialsCallback will attempt to read/write on a closed pipe.