search

libgit2 / libgit2sharp.nativebinaries

MIT License
28 stars 62 forks source link

Binaries for newer versions of libgit2? #110

Closed tompazourek closed 3 years ago

tompazourek commented 3 years ago

The latest version of libgit2sharp.nativebinaries NuGet package contains binaries for the version 0.28.0 of libgit2. However, there have been many releases since:

They contain some useful fixes that would be nice to have. Are there any plans to publish binaries for these newer versions?

Thanks

DvdKhl commented 3 years ago

I'm also wondering if there is a particular reason why it isn't updated to a newer version.

I've cloned both repositories libgit2sharp and this one, made a few changes to get it running with net5 and Visual Studio 2019. Then I've updated/compiled/packaged this repo to use the source of libgit2 1.1.0 with the provided scripts.

Then I ran the tests in LibGit2Sharp.Tests (which uses the new binary package) and only 5 tests failed: image

I think it would be nice to have an additional nuget alpha preview release of libgit2sharp with the 1.1.0 binaries, so more people are able to test it.

rgl commented 3 years ago

This now seems to be available at:

But it seems there is no one looking at this project anymore :-(

jairbubbles commented 3 years ago

@DvdKhl With the package produced by #114 I was able to run all tests successfully with only a few minor changes. "origin/HEAD" is now added when cloning (see https://github.com/libgit2/libgit2/pull/5651) and some tests are failing because they are counting the branches after clone.

I didn't have any issue with CanGetBlobAsTextWithVariousEncodings or NoPublicTypesUnderLibGit2SharpCoreNamespace.

I will create a PR but I need to reference the new package which is not on nuget.org for the CI to pass.

bording commented 3 years ago

@jairbubbles #114 has been merged, and I've published 2.0.315-alpha.0.1 with the changes.

jairbubbles commented 3 years ago

Looks awesome to me!

jairbubbles commented 3 years ago

I create a draft PR here in libGit2Sharp => https://github.com/libgit2/libgit2sharp/pull/1905/

bording commented 3 years ago

Since we now have packages up on nuget.org with newer versions, I'm going to go ahead and close this.