search

libgit2 / libgit2sharp.nativebinaries

MIT License
29 stars 63 forks source link

Update libgit2 to v1.1.1 #114

Closed jairbubbles closed 3 years ago

jairbubbles commented 3 years ago

I'm trying to update libgit2 to a more recent version to get support for the sparse checkout (see https://github.com/libgit2/libgit2sharp/issues/1845)

jairbubbles commented 3 years ago

Thanks for the info @A-Ovchinnikov-mx ! It's too bad we can't all work on the upstream repository 😭

ethomson commented 3 years ago

You can. LibGit2Sharp needs a maintainer. Maybe that person is you!? https://github.com/libgit2/libgit2sharp/issues/1834

ghost commented 3 years ago

I would love to help but I'm a bit afraid I won't be able to dedicate too much time to it 😬 And that would be my personal investment, not from the company. If that's already good enough, then I can drop a message in that thread from my personal GitHub account.

jairbubbles commented 3 years ago

Hello @bording, I saw you did some modification recently and I was wondering what do you think of moving forward with the libgit version? A new version 1.1.1 was also published that we could target.

I looked at @A-Ovchinnikov-mx commits but the fixes need to be done on libgit2sharp side. (It's linked to https://github.com/libgit2/libgit2/pull/5117)

bording commented 3 years ago

Hello @bording, I saw you did some modification recently and I was wondering what do you think of moving forward with the libgit version? A new version 1.1.1 was also published that we could target.

My plan is to move up to a newer version of libgit2, but I was hoping to wait for https://github.com/libgit2/libgit2/pull/5974 land first.

jairbubbles commented 3 years ago

I'm not particularly in a hurry so that's fine with me to wait for a newer version. In the meantime, would it be possible to publish an alpha version of the native binaries NuGet packages so that I can create a draft PR on libgit2sharp repo to make sure the CI is all green?