search

libgit2 / libgit2sharp.nativebinaries

MIT License
29 stars 63 forks source link

Update libgit2 to v1.2.0 #126

Closed jairbubbles closed 3 years ago

jairbubbles commented 3 years ago
bording commented 3 years ago

As part of this PR, let's go ahead and update https://github.com/libgit2/libgit2sharp.nativebinaries/blob/master/build.libgit2.sh#L14 to be OpenSSL-Dynamic instead of OFF.

jairbubbles commented 3 years ago

Sure I'll give it a shot!

jairbubbles commented 3 years ago

I updated the value blindly, looks like it's all green!

ethomson commented 3 years ago

I'm hopeful that this is a better outcome than the managed transport was. 🤞

bording commented 3 years ago

I'm hopeful that this is a better outcome than the managed transport was. 🤞

@ethomson Would a similar approach for SSH support be possible? Being able to optionally support SSH and not need to worry about bundling libraries for it would be great.

bording commented 3 years ago

2.0.315-alpha.0.2 has been uploaded to nuget.org

ethomson commented 3 years ago

Would a similar approach for SSH support be possible? Being able to optionally support SSH and not need to worry about bundling libraries for it would be great.

Possible, yes - but I don't have an estimate of the amount of work. I'm not super familiar with libssh2 or our use of it. I think that my big hesitation is that libssh2 doesn't appear to be a particular amazing library and hasn't seen many updates lately, IIRC. I worry that it would be a decent amount of effort for a disappointing result.

bording commented 3 years ago

Would a similar approach for SSH support be possible? Being able to optionally support SSH and not need to worry about bundling libraries for it would be great.

Possible, yes - but I don't have an estimate of the amount of work. I'm not super familiar with libssh2 or our use of it. I think that my big hesitation is that libssh2 doesn't appear to be a particular amazing library and hasn't seen many updates lately, IIRC. I worry that it would be a decent amount of effort for a disappointing result.

That all makes sense. It was just something I was wondering about since it seems like the majority of the LibGit2Sharp forks and alternate NuGet packages on nuget.org are related to SSH support.