search

libgit2 / libgit2sharp.nativebinaries

MIT License
29 stars 63 forks source link

Build native libs for linux-musl-arm and linux-musl-arm64 #130

Closed arturcic closed 3 years ago

arturcic commented 3 years ago

Made the docker files use base images from multiarch/crossbuild and multiarch/alpine to make it easier to maintain.

Added support for linux-musl-arm and linux-musl-arm64.

Publishing the resulted nuget package only when it's manually run the workflow to GitHub Packages. (This allows to have the nuget package available to be consumed in other repository - libgit2sharp for example). I have a fork of libgit2sharp that does test the native libs with libgit2sharp on multiple linux distros and arm64/amd64 (check this out https://github.com/arturcic/libgit2sharp/actions/runs/1366916943). If this one gets merged I will also submit a PR to the libgit2sharp repo to include that worflow as well

arturcic commented 3 years ago

@bording is there anything I can do to have a progress on this PR?

bording commented 3 years ago

I took an initial look at this weekend (and let the CI run) but didn't have time to dig into the changes in-depth yet. It's on my todo list.

bording commented 3 years ago

In addition to the comments above, I noticed that you open this PR against the master branch of your fork. Would it be possible to instead create a branch and open a new PR using that instead?

arturcic commented 3 years ago

In addition to the comments above, I noticed that you open this PR against the master branch of your fork. Would it be possible to instead create a branch and open a new PR using that instead?

I close this PR in favor of https://github.com/libgit2/libgit2sharp.nativebinaries/pull/133