search

libgit2 / libgit2sharp.nativebinaries

MIT License
28 stars 62 forks source link

Build native libs for linux-musl-arm and linux-musl-arm64 #133

Closed arturcic closed 2 years ago

arturcic commented 2 years ago

See #130 for initial PR.

I commented on the changes on the original PR. I think we need to continue the discussion here. This PR is made from a branch instead of master

bording commented 2 years ago

I did also merge #132 which has introduced a conflict here, sorry about that!

arturcic commented 2 years ago

I did also merge #132 which has introduced a conflict here, sorry about that!

I'm glad that that one was merged. I'll rebase my changes and will work on changes you requested

arturcic commented 2 years ago

@bording rebased and fixed according change requests.

arturcic commented 2 years ago

@bording thank you for merging this one. Do you have any plans to release a new version of the package?

bording commented 2 years ago

@bording thank you for merging this one. Do you have any plans to release a new version of the package?

Yep, just waiting for the linux-musl builds to finish, they are so slow!

arturcic commented 2 years ago

Agree, one of the reasons I wanted to run in parallel. Any plans also to release a LibGit.Sharp new version to reference the new native package?

bording commented 2 years ago

Agree, one of the reasons I wanted to run in parallel.

I looked at the build times between CI runs with and without the parallel setting, and it wasn't a clear win. Some things got a little bit faster, but the only things that really matter are the musl-arm builds.

The linux-musl-arm64 build does see some big improvements with the parallel setting, but the linux-musl-arm build appears to get slower with the setting, removing any gains and making the total build time about the same.

Any plans also to release a LibGit.Sharp new version to reference the new native package?

I won't be able to get to that today, so if you wanted to open a PR that included an update to the new native binaries package and introduced some additional linux distros into the testing matrix, that would be appreciated.

arturcic commented 2 years ago

I won't be able to get to that today, so if you wanted to open a PR that included an update to the new native binaries package and introduced some additional linux distros into the testing matrix, that would be appreciated.

I will have a look

bording commented 2 years ago

2.0.315-alpha.0.7 has been pushed to nuget.org.