search

libgit2 / libgit2sharp.nativebinaries

MIT License
28 stars 62 forks source link

Allow custom DLL names #17

Closed ethomson closed 9 years ago

ethomson commented 9 years ago

Like in the pre-NuGet native binary days, we require a way to have a custom libgit2 filename, for example git2-visualstudio.dll. This updates the build and update scripts to include support for this, as well as the ability to then output a custom NuGet package suffix so that we do not confuse our binary packages with the official ones.

This also adds a README.md describing how to work with this system.

ethomson commented 9 years ago

Oh, doh, @nulltoken - I didn't realize that you had a README in another PR. Let me know if you want me to drop that commit and we can figure something else out.

bording commented 9 years ago

Since the changes in libgit2/libgit2sharp#1157 require libgit2_filename.txt to exist in the package, this file also needs to be commited with the standard naming scheme.

Other than that, I think this looks good. I don't see anything in this that would break on the mono side of things when using a custom name. Did you by any chance test that to confirm? If not, I can double check that.

Therzok commented 9 years ago

@bording as long as the dllimport's name is regenerated, nothing will break on mono side.

bording commented 9 years ago

@Therzok My comment was more about making sure the custom name was actually propagated out to the appropriate places for mono to see it, for example the LibGit2Sharp.dll.config file, and it looks like that is all being handled correctly.

ethomson commented 9 years ago

Since the changes in libgit2/libgit2sharp#1157 require libgit2_filename.txt to exist in the package, this file also needs to be commited with the standard naming scheme.

Makes sense. Fixed that up. Thanks.

nulltoken commented 9 years ago

Oh, doh, @nulltoken - I didn't realize that you had a README in another PR. Let me know if you want me to drop that commit and we can figure something else out.

Are you kidding me? This is an amazing README! Of course, you keep it.

However, I wouldn't mind some :eyes: on #5 :wink:

ethomson commented 9 years ago

@nulltoken I made some changes, but I didn't broadly include #5 yet. There's some very good stuff in there and we should merge the two documents for sure, but I didn't do that as part of this PR.

nulltoken commented 9 years ago

@ethomson Neat!