NuGet package broken for xbuild builds

libgit2 / libgit2sharp.nativebinaries

MIT License

28 stars 62 forks source link

NuGet package broken for xbuild builds #25

Closed ermshiperete closed 8 years ago

ermshiperete commented 8 years ago

When using the libgit2sharp.nativebinaries package on Linux/Mono the files don't get copied over to the output directory because xbuild currently doesn't honor imported ItemGroups.

I think it would be better to use a target instead of the properties.

bording commented 8 years ago

Where are you seeing this behavior? LibGit2Sharp itself uses the nativebinaries package, and the Travis CI builds use xbuild and everything works correctly there.

ermshiperete commented 8 years ago

Oops, sorry. Now I feel stupid. Yes, it works completely fine, and it's the build script in GitVersion that copies only part of the files. I really shouldn't submit bugs or PRs when I'm not completely awake :smile: