The props file now includes files with ContentWithTargetPath instead of None which means the files will still get copied where they need to go, but they won't show up as items in Solution Explorer.
Instead of adding libgit2_hash.txt and libgit2_filename.txt to assemblies as embedded resources, those values are now added as MSBuild properties. I'll then be able to use those in the relevant target files in LibGit2Sharp.
There are now two props files, one for net461 and greater, which has all of the file copying stuff in it as usual, and one that will be referenced when using anything other than .NET Framework TFMs. That one only has the new MSBuild properties in it. This is primarily here so LibGit2Sharp has access to it since it will be netstandard2.0 only soon. We don't need any of file copy stuff there.
@ethomson Any objections to me merging this and then getting a new package up on nuget.org?
ethomson
commented
6 years ago
This includes the following changes:
The props file now includes files with
ContentWithTargetPathinstead ofNonewhich means the files will still get copied where they need to go, but they won't show up as items in Solution Explorer.Instead of adding libgit2_hash.txt and libgit2_filename.txt to assemblies as embedded resources, those values are now added as MSBuild properties. I'll then be able to use those in the relevant target files in LibGit2Sharp.
There are now two props files, one for net461 and greater, which has all of the file copying stuff in it as usual, and one that will be referenced when using anything other than .NET Framework TFMs. That one only has the new MSBuild properties in it. This is primarily here so LibGit2Sharp has access to it since it will be netstandard2.0 only soon. We don't need any of file copy stuff there.
@ethomson Any objections to me merging this and then getting a new package up on nuget.org?