search

libgit2 / libgit2sharp

Git + .NET = ❤
http://libgit2.github.com
MIT License
3.16k stars 889 forks source link

Problem in picking up libgit2-7ce88e6 in fedora29 #1730

Open adaggarwal opened 4 years ago

adaggarwal commented 4 years ago

Reproduction steps

Build source-build without explicitly exporting LD_PATH in fedora29.

Expected behavior

libgit2-7ce88e6 gets picked up automatically from source-build dotnet path after it fails to find it in the environment

Actual behavior

Without explicitly exporting the path, this fails on fedora but passes in other distros such as centos and ubuntu

Version of LibGit2Sharp (release number or SHA1)

0e8a3cabe8e05b2052237f5dbcd60476ef22d7a5 0.27.0-preview-0024

Operating system(s) tested; .NET runtime tested

fedora29 docker image runtime - 2.1.0

omajid commented 4 years ago

This should have been fixed by https://github.com/libgit2/libgit2sharp/pull/1714.

tmds commented 4 years ago

fedora29 docker image runtime - 2.1.0

This should have been fixed by #1714.

That fix applies to .NET Core 3.0+. Earlier versions don't have the NativeLibrary class that is used by the fix.