search

libgit2 / libgit2sharp

Git + .NET = ❤
http://libgit2.github.com
MIT License
3.16k stars 888 forks source link

Adjust GitStatusOptions to match structure of native libgit2 #1884

Closed Molytho closed 3 years ago

Molytho commented 3 years ago

This fixes a marshaling bug that causes a segmentation fault

This mismatch caused dotdevelop's git module to crash. More about this can be found here: https://github.com/dotdevelop/libgit2sharp/issues/2

codecov-commenter commented 3 years ago

Codecov Report

Merging #1884 (b78b290) into master (df3b22a) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1884   +/-   ##
=======================================
  Coverage   84.60%   84.61%           
=======================================
  Files         231      231           
  Lines        9174     9175    +1     
=======================================
+ Hits         7762     7763    +1     
  Misses       1412     1412
Impacted Files Coverage Δ
LibGit2Sharp/Core/GitStatusOptions.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df3b22a...b78b290. Read the comment docs.

stefanloerwald commented 3 years ago

Can we get this merged soon? Turns out this is the reason every status query fails with the most recent dotnet runtime (5.0.7).

Thanks! Stefan

stefanloerwald commented 3 years ago

Hi @bording, I'm tagging you here, because you seem to be the member of libgit2 who most recently interacted with this repository. Quite a few people are affected by this issue here. Any chance you can release a new (preview) version after merging this PR?

Thanks Stefan

bording commented 3 years ago

This change has been published as 0.27.0-preview-0100.

stefanloerwald commented 3 years ago

Thank you so much, @bording. Now libgit2sharp is working again with the most recent dotnet runtime. Awesome!