On MacOS, `Repository.Init` yields different `WorkingDirectory` than provided in constructor

leonardochaia commented 2 years ago

Hi all, we are using lib2gitsharp in dotnet-affected, a tool to detect which projects are affected by a set of changes.

I am not sure if this is a MacOS thing, or expected behavior. I couldn't find any related Issue or StackOverflow post.

Reproduction steps

Creating a new repository in MacOS using Repository.Init is prefixing a /private folder.

public void TestRepoPaths()
{
    using var directory = new TempWorkingDirectory();

    Repository.Init(directory.Path);
    using var repo = new Repository(directory.Path);

    var workDir = Path.TrimEndingDirectorySeparator(repo.Info.WorkingDirectory);

    Assert.Equal(directory.Path, workDir);
}

logs:

Request create repo at /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Temporary5b072d08b1104c0cbf3ef3cf5c804bfa
Output Git Init /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Temporary5b072d08b1104c0cbf3ef3cf5c804bfa/.git/
Repo Path: /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Temporary5b072d08b1104c0cbf3ef3cf5c804bfa/.git/
Repo Workdir: /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/Temporary5b072d08b1104c0cbf3ef3cf5c804bfa/

Link to complete reproduction example

Link to build results passing on Windows and ubuntu, but not MacOS

Expected behavior

When using var repo = new Repository(workingDirectoryPath) on MacOs, I would expect repo.Info.WorkingDirectory to equal the received workingDirectoryPath.

Actual behavior

When using var repo = new Repository(workingDirectoryPath) on MacOS, repo.Info.WorkingDirectory does not equal the provided workingDirectoryPath.

Under Windows and Linux the same path is returned.