search

libgit2 / libgit2sharp

Git + .NET = ❤
http://libgit2.github.com
MIT License
3.12k stars 878 forks source link

LibGit2Sharp: update to libgit2 v1.6.2 #2015

Closed ethomson closed 1 year ago

ethomson commented 1 year ago

still haven't figured out what's changed that's affecting #1957 as well. 🙃

bording commented 1 year ago

still haven't figured out what's changed that's affecting https://github.com/libgit2/libgit2sharp/pull/1957 as well. 🙃

I never could figure it out after spending a decent amount of time on it, pretty much bringing any progress here to a halt.

ethomson commented 1 year ago

I think the last problem is https://github.com/libgit2/libgit2/pull/6506

Balkoth commented 1 year ago

After building with https://github.com/libgit2/libgit2/pull/6506 only one test fails:

image

PR https://github.com/libgit2/libgit2/commit/acb00e4eae66bfed84046bccb60bf59707fe9626 introduced another builtin extension 'objectformat' which has to be added to the test i think.

Once this is done i hope we can get a new release ✌

ethomson commented 1 year ago

@Balkoth to clarify - are you building with this PR and seeing failures around objectformat? It should take the objectformat changes into account. 🤔

Balkoth commented 1 year ago

Oh sorry, i did not use this PR to check, i used what i checked out from the head last week. Obviously this PR fixes the test failures around objectformat 👍

ethomson commented 1 year ago

Oh sorry, i did not use this PR to check, i used what i checked out from the head last week. Obviously this PR fixes the test failures around objectformat 👍

No worries @Balkoth - appreciate the update!

arturcic commented 1 year ago

@ethomson any plans on releasing to nuget?