libgit2 / libgit2sharp

Git + .NET = ❤
http://libgit2.github.com
MIT License
3.12k stars 878 forks source link

Can't access GIT config (Repository.Config) since v0.27.0 #2031

Closed ozanneconsulting closed 1 year ago

ozanneconsulting commented 1 year ago

Reproduction steps

Open an existing repository: Repository localRepository = new Repository(localPath);

Access localRepository.Config

Expected behavior

Repository.Config gives access to GIT configuration

Actual behavior

Any access of Repository.Config throws an exception:

the ProgramData file 'config' doesn't exist: at LibGit2Sharp.Core.Ensure.HandleError(Int32 result) in //LibGit2Sharp/Core/Ensure.cs:line 154 at LibGit2Sharp.Core.Proxy.ConvertPath(Func`2 pathRetriever) in //LibGit2Sharp/Core/Proxy.cs:line 3801 at LibGit2Sharp.Configuration..ctor(Repository repository, String repositoryConfigurationFileLocation, String globalConfigurationFileLocation, String xdgConfigurationFileLocation, String systemConfigurationFileLocation) in /_/LibGit2Sharp/Configuration.cs:line 46 at LibGit2Sharp.Repository.<>c__DisplayClass25_1.<.ctor>b_3() in //LibGit2Sharp/Repository.cs:line 220 at System.Lazy1.ViaFactory(LazyThreadSafetyMode mode) --- End of stack trace from previous location --- at System.Lazy1.CreateValue()

Version of LibGit2Sharp (release number or SHA1)

0.27.0 et 0.27.1 (it works fine in 0.26.2

Operating system(s) tested; .NET runtime tested

Windows 11, .NET 6.0, console application.

ozanneconsulting commented 1 year ago

This is a duplicate of #2021

bording commented 1 year ago

@ozanneconsulting This is actually a slightly different scenario than #2021, so I'm reopening it. #2021 is talking about the behavior when using the default constructor, and your issue is about when you've passed a path to an actual repo.

arturcic commented 1 year ago

@bording can we have a new release ?

bording commented 1 year ago

Fixed in LibGit2Sharp v0.27.2.

ozanneconsulting commented 1 year ago

@bording I confirm this release fixes my problem. Thanks for your unbelievable reactivity.

ethomson commented 1 year ago

Glad to hear it. Seconding my thanks to @bording. 🎉